Bug 1254 – cups-filters cannot be compiled with poppler 0.31.0

Bug 1254 - cups-filters cannot be compiled with poppler 0.31.0

Summary:

cups-filters cannot be compiled with poppler 0.31.0

Status:	RESOLVED FIXED

Product:	OpenPrinting
Classification:	Unclassified
Component:	cups-filters
Version:	unspecified
Platform:	All Linux

Importance:	P2 normal
Assigned To:	Till Kamppeter

URL:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2015-02-05 22:05 UTC by Alex K
Modified:	2015-02-18 03:25 UTC (History)
CC List:	7 users (show)

See Also:

Attachments
Build Fix (1.74 KB, patch) 2015-02-10 20:56 UTC, Armin K.	Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alex K 2015-02-05 22:05:58 UTC

getAntialias method has been removed from GlobalParams class, and cups-filters 1.0.62 now fails to compile. 

filter/pdftoopvp/OPVPOutputDev.cxx: In member function 'void OPVPOutputDev::startDoc(XRef*)':
filter/pdftoopvp/OPVPOutputDev.cxx:281:23: error: 'class GlobalParams' has no member named 'getAntialias'

Comment 1 Till Kamppeter 2015-02-06 22:25:35 UTC

*** Bug 1256 has been marked as a duplicate of this bug. ***

Comment 2 octoploid 2015-02-07 07:14:50 UTC

There are more issues later on:

filter/pdftoijs.cxx:439:41: error: no matching function for call to â€˜SplashOutputDev::SplashOutputDev(SplashColorMode&, int&, GBool&, SplashColor, bool, bool)â€™
     reverseVideo,paperColor,gTrue,gFalse);
                                         ^
In file included from filter/pdftoijs.cxx:41:0:
/usr/include/poppler/SplashOutputDev.h:171:3: note: candidate: SplashOutputDev::SplashOutputDev(SplashColorMode, int, GBool, SplashColorPtr, GBool, SplashThinLineMode, GBool)
   SplashOutputDev(SplashColorMode colorModeA, int bitmapRowPadA,
   ^
/usr/include/poppler/SplashOutputDev.h:171:3: note:   no known conversion for argument 6 from â€˜boolâ€™ to â€˜SplashThinLineModeâ€™
/usr/include/poppler/SplashOutputDev.h:167:7: note: candidate: SplashOutputDev::SplashOutputDev(const SplashOutputDev&)
 class SplashOutputDev: public OutputDev {
       ^
/usr/include/poppler/SplashOutputDev.h:167:7: note:   candidate expects 1 argument, 6 provided
Makefile:3314: recipe for target 'pdftoijs-pdftoijs.o' failed
make[1]: *** [pdftoijs-pdftoijs.o] Error 1

Comment 3 Armin K. 2015-02-10 20:56:34 UTC

Created attachment 476 [details]
Build Fix

At least this gets it to build. Diff against 1.0.62

Comment 4 Till Kamppeter 2015-02-18 03:22:59 UTC

Applied the patch (with small correction) as BZR rev. 7332.

Thanks, Armin K., for the patch.

I have modified the conditionals, instead of

#if POPPLER_VERSION_MAJOR > 0 || POPPLER_VERSION_MINOR <= 30

I have put

#if POPPLER_VERSION_MAJOR == 0 && POPPLER_VERSION_MINOR <= 30

The former would mean "for versions up to 0.30 AND version 1.0 and newer", the latter "for versions up to 0.30" which is meant here.

Comment 5 Till Kamppeter 2015-02-18 03:24:58 UTC

Please also test whether the filter actually works as intended with Poppler 0.31.0 (and not only builds).